Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-412] Validate caller DON membership in TriggerPublisher #14040

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[KS-412] Validate caller DON membership in TriggerPublisher #14040

merged 3 commits into from
Aug 8, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Aug 5, 2024

Sender needs to actually belong to the DON on behalf of which it is subscribing trigger events.

@bolekk bolekk requested a review from a team August 5, 2024 23:00
@bolekk bolekk requested a review from a team as a code owner August 5, 2024 23:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@bolekk bolekk changed the title [KS-412] Validate called DON membership in TriggerPublisher [KS-412] Validate caller DON membership in TriggerPublisher Aug 6, 2024
@bolekk bolekk force-pushed the bugfix/KS-412-validate-donid branch from 1d97121 to 593fef4 Compare August 8, 2024 03:20
@bolekk
[KS-412] Validate called DON membership in TriggerPublisher
01be507 
Sender needs to actually belong to the DON on behalf of which it is subscribing trigger events.
@bolekk bolekk force-pushed the bugfix/KS-412-validate-donid branch from 593fef4 to 01be507 Compare August 8, 2024 03:30
@bolekk bolekk requested review from cedric-cordenier, ettec and a team August 8, 2024 03:43
@bolekk bolekk enabled auto-merge August 8, 2024 15:35
@bolekk bolekk added this pull request to the merge queue Aug 8, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 0f166ad Aug 8, 2024
118 of 119 checks passed
@bolekk bolekk deleted the bugfix/KS-412-validate-donid branch August 8, 2024 16:03
momentmaker added a commit that referenced this pull request Aug 8, 2024
@momentmaker
Merge branch 'develop' into re-2756/goreleaser-build-image
4d17c65 
* develop:
  CRIB CI integration (#13924)
  fix: refactor sonarqube scan args (#13875)
  BCI-3492 [LogPoller]: Allow withObservedExecAndRowsAffected to report non-zero rows affected (#14057)
  Add error mapping for Astar (#13990)
  [BCI-3862][chainlink] - Change DSL Block primitive to string instead of int (#14033)
  [KS-412] Validate called DON membership in TriggerPublisher (#14040)
  [TT-1429] notifying guardian on some failures (#14073)
  Add Mantle errors (#14053)
  Fix write target nil dereferences (#14059)
  Allow retrying failed transmissions (#14017)
  auto-11214: migrate more tests to foundry (#13934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@DeividasK DeividasK DeividasK approved these changes

@ettec ettec Awaiting requested review from ettec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolekk @DeividasK @cedric-cordenier